Stream: git-wasmtime

Topic: wasmtime / PR #2961 Use the host's target ISA in the fron...

Wasmtime GitHub notifications bot (Jun 02 2021 at 20:25):

abrown opened PR #2961 from fix-x86-target to main:

Commit 7d36fd9a1e070e2d83f8b63e44faae587a138686 avoided these
x86-specific tests altogether. This change attempts to run the tests on
whichever backend is native to the current host system.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Jun 02 2021 at 20:32):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2021 at 22:28):

abrown updated PR #2961 from fix-x86-target to main.

Wasmtime GitHub notifications bot (Jun 03 2021 at 09:55):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2021 at 09:55):

bnjbvr created PR review comment:

I think you could get the default calling convention from the TargetIsa object, and then use it to generate the calling convention in the expected string below. Not sure if it works for all the cases, though.

Wasmtime GitHub notifications bot (Jun 03 2021 at 09:55):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2021 at 16:01):

abrown updated PR #2961 from fix-x86-target to main.

Wasmtime GitHub notifications bot (Jun 03 2021 at 16:58):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2021 at 16:58):

abrown created PR review comment:

Ok, I ended up changing the approach... I am just trying various things based on the discussion here.

Last updated: Dec 23 2024 at 12:05 UTC