Wasmtime GitHub notifications bot (Jun 03 2021 at 17:24): Wasmtime GitHub notifications bot (Jun 03 2021 at 17:24):abrown edited PR #2961 from fix-x86-target to main.
Wasmtime GitHub notifications bot (Jun 03 2021 at 17:25):abrown edited PR #2961 from fix-x86-target to main:
~~Commit 7d36fd9a1e070e2d83f8b63e44faae587a138686 avoided these
x86-specific tests altogether. This change attempts to run the tests on
whichever backend is native to the current host system.[edit: based on @bjorn3's suggestion, here is a slightly different approach. I think this resolves the concerns about not running these tests on certain systems. Also, it factors out some duplicated code.]
Commit 7d36fd9 avoided these
x86-specific tests altogether. This change forces the x86 backend to be
present when the frontend tests are run.~~[edit: @bjorn3's final suggestion is actually the best--just avoid any backend-specific dependency entirely]
Commit 7d36fd9 avoided these
x86-specific tests altogether. This change avoids any dependency on x86
entirely by specifying a frontend configuration (SystemV + U64); this is
enough information for theFunctionBuilderto correctly generate the
syscalls.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2021 at 17:26):abrown edited PR #2961 from fix-x86-target to main:
~~Commit 7d36fd9a1e070e2d83f8b63e44faae587a138686 avoided these
x86-specific tests altogether. This change attempts to run the tests on
whichever backend is native to the current host system.~~[edit: based on @bjorn3's suggestion, here is a slightly different approach. I think this resolves the concerns about not running these tests on certain systems. Also, it factors out some duplicated code.]
~~Commit 7d36fd9 avoided these
x86-specific tests altogether. This change forces the x86 backend to be
present when the frontend tests are run.~~[edit: @bjorn3's final suggestion is actually the best--just avoid any backend-specific dependency entirely]
Commit 7d36fd9 avoided these
x86-specific tests altogether. This change avoids any dependency on x86
entirely by specifying a frontend configuration (SystemV + U64); this is
enough information for theFunctionBuilderto correctly generate the
syscalls.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2021 at 17:35):bjorn3 submitted PR review.
Wasmtime GitHub notifications bot (Jun 03 2021 at 17:45):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 03 2021 at 18:01):abrown merged PR #2961.
Last updated: Nov 22 2024 at 17:03 UTC