Stream: git-wasmtime

Topic: wasmtime / PR #2956 CI: put tests into a separate script ...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 10:32):

bnjbvr opened PR #2956 from run-test-script to main:

This streamlines running the tests, and has the benefits to make it trivial to locally run tests as they're run in CI (viz. use ./ci/run-tests.sh) and makes the cargo test flags uniform across testing, including for the old-x86-backend.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 10:36):

bnjbvr updated PR #2956 from run-test-script to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 14:13):

alexcrichton created PR review comment:

Could this perhaps be "$@" to just forward all arguments to cargo test (and placed at the end). That way the --locked could also be passed in only with CI to make this a bit more useful to run locally.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 14:13):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 14:47):

bnjbvr created PR review comment:

Good idea, it's also more future-proof!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 14:47):

bnjbvr submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 14:47):

bnjbvr updated PR #2956 from run-test-script to main.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 15:20):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 15:28):

bnjbvr merged PR #2956.

Last updated: Nov 22 2024 at 16:03 UTC