Stream: git-wasmtime

Topic: wasmtime / PR #2955 cranelift: introduce a new WasmtimeAp...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 09:46):

bnjbvr opened PR #2955 from wasmtime-apple-aarch64-cc to main:

The previous choice to use the WasmtimeSystemV calling convention for
apple-aarch64 devices was incorrect: padding of arguments was
incorrectly computed. So we have to use some flavor of the apple-aarch64
ABI there.

Since we want to support the wasmtime custom convention for multiple
returns on apple-aarch64 too, a new custom Wasmtime calling convention
was introduced to support this.

As a matter of fact, the wasmtime tests using many arguments were broken on trunk, when being run on my M1 machine. I'll look into ways to automate testing on our side, and share the results with a broader audience.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 14:18):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2021 at 15:29):

bnjbvr merged PR #2955.

Last updated: Oct 23 2024 at 20:03 UTC