Stream: git-wasmtime

Topic: wasmtime / PR #2952 make ResourceLimiter operate on Store...

Wasmtime GitHub notifications bot (May 28 2021 at 23:48):

pchickey opened PR #2952 from pch/limiter_in_store_data to main:

Based on #2897 - draft until that PR lands.

This PR does two things:

• The ResourceLimiter trait is now implemented on the data inside a Store rather than as a standalone owned type. This change required changing the structure of the Store internals a bunch. Additionally, the trait is now defined in wasmtime_runtime and re-exported by wasmtime.
• Two new functions, entering_native_code_hook and exiting_native_code_hook, are added to Store. These functions get to operate on the data inside a Store much like resource limiter's mut methods. These functions give embedding the opportunity to measure time (or other resources) and trap before entering any native code (i.e. a Func) linked into the Store, and again before returning from that native code.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 28 2021 at 23:48):

pchickey requested alexcrichton for a review on PR #2952.

Wasmtime GitHub notifications bot (Jun 03 2021 at 22:00):

pchickey updated PR #2952 from pch/limiter_in_store_data to main.

Wasmtime GitHub notifications bot (Jun 03 2021 at 22:01):

pchickey has marked PR #2952 as ready for review.

Wasmtime GitHub notifications bot (Jun 03 2021 at 22:14):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 03 2021 at 22:33):

pchickey updated PR #2952 from pch/limiter_in_store_data to main.

Wasmtime GitHub notifications bot (Jun 03 2021 at 22:59):

pchickey updated PR #2952 from pch/limiter_in_store_data to main.

Wasmtime GitHub notifications bot (Jun 04 2021 at 14:11):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 04 2021 at 14:11):

alexcrichton created PR review comment:

Is the as &mut dyn ResourceLimiter required here in that rustc can't infer it?

Wasmtime GitHub notifications bot (Jun 04 2021 at 14:12):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 04 2021 at 14:12):

alexcrichton created PR review comment:

Oh how come this change was necessary? I didn't think we even gave access to the Store...

Wasmtime GitHub notifications bot (Jun 04 2021 at 14:15):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jun 04 2021 at 14:15):

bjorn3 created PR review comment:

|s| s doesn't attempt to coerce s AFAIK.

Wasmtime GitHub notifications bot (Jun 04 2021 at 16:09):

pchickey created PR review comment:

This is used over in the fuzzing crate, which uses a resource limiter. So, while previously the store could have a () data and also own a dyn ResourceLimiter, now the store has to contain the dyn ResourceLimiter.

Wasmtime GitHub notifications bot (Jun 04 2021 at 16:09):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 04 2021 at 22:51):

pchickey updated PR #2952 from pch/limiter_in_store_data to main.

Wasmtime GitHub notifications bot (Jun 07 2021 at 19:13):

pchickey updated PR #2952 from pch/limiter_in_store_data to main.

Wasmtime GitHub notifications bot (Jun 07 2021 at 22:24):

pchickey updated PR #2952 from pch/limiter_in_store_data to main.

Wasmtime GitHub notifications bot (Jun 08 2021 at 14:37):

alexcrichton merged PR #2952.

Last updated: Nov 22 2024 at 16:03 UTC