Wasmtime GitHub notifications bot (May 27 2021 at 23:14): Wasmtime GitHub notifications bot (May 27 2021 at 23:14):pchickey opened PR #2947 from pch/global_module_rwlock to main:
Based on #2897 - draft until that lands
@acfoltzer identified this on a code walk through wasmtime with me,
and it was already noted in a comment that we could change if motivated.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (May 27 2021 at 23:14):pchickey requested alexcrichton for a review on PR #2947.
Wasmtime GitHub notifications bot (May 28 2021 at 14:50):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 03 2021 at 21:52):pchickey updated PR #2947 from pch/global_module_rwlock to main.
Wasmtime GitHub notifications bot (Jun 03 2021 at 21:52):pchickey edited PR #2947 from pch/global_module_rwlock to main:
@acfoltzer identified this on a code walk through wasmtime with me,
and it was already noted in a comment that we could change if motivated.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Jun 03 2021 at 21:52):pchickey has marked PR #2947 as ready for review.
Wasmtime GitHub notifications bot (Jun 03 2021 at 22:03):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jun 03 2021 at 23:30):pchickey merged PR #2947.
Last updated: Dec 23 2024 at 12:05 UTC