Stream: git-wasmtime

Topic: wasmtime / PR #2917 wasmtime-wasi: re-exporting this Wasi...

Wasmtime GitHub notifications bot (May 20 2021 at 22:44):

pchickey opened PR #2917 from pch/wasmtime_wasi_reexport_mess to main:

wasi-common's WasiCtxBuilder is really only useful wasi_cap_std_sync and
wasi_tokio to implement their own Builder on top of.

This re-export of wasi-common's is 1. not useful and 2. shadow's the
re-export of the right one in sync::*.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 20 2021 at 23:11):

pchickey updated PR #2917 from pch/wasmtime_wasi_reexport_mess to main.

Last updated: Dec 23 2024 at 12:05 UTC