Stream: git-wasmtime

Topic: wasmtime / PR #2915 Implement std::fmt::Debug for Interru...

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 00:48):

theduke opened PR #2915 from interrupt-handle-debug to main:

Just a basic fmt::Debug implementation for InterrutpHandle.

Motiviation: it's annoying to manually implement Debug for types which hold
a handle.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 10:34):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 10:34):

bjorn3 created PR review comment:

VMInterrupts implements Debug, so you should be able to derive Debug for InterruptHandle.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 14:17):

theduke submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 14:17):

theduke created PR review comment:

VMInterrupts is a private imiplementation detail though, with no way to access it via the handle.

I feel including it in the debug output would be more confusing than helpful.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 14:18):

theduke edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 14:19):

theduke edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 14:22):

theduke edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 15:51):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 15:51):

bjorn3 created PR review comment:

Maybe you could at least expose the Arc pointer? That would allow for distinguishing between multiple InterruptHandle instances.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 16:46):

theduke updated PR #2915 from interrupt-handle-debug to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 16:46):

theduke submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 16:46):

theduke created PR review comment:

In that case it seems more sensible to just derive it.

Pushed an update.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 16:48):

theduke updated PR #2915 from interrupt-handle-debug to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 20 2021 at 17:16):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2021 at 15:54):

alexcrichton merged PR #2915.

Last updated: Dec 23 2024 at 12:05 UTC