abrown opened PR #2898 from fix-2883
to main
:
This fixes #2883 by restricting which types are available to the
uadd_sat
,sadd_sat
,usub_sat
, andssub_sat
IR operations.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
abrown requested bnjbvr for a review on PR #2898.
abrown updated PR #2898 from fix-2883
to main
.
bnjbvr submitted PR review.
abrown updated PR #2898 from fix-2883
to main
.
abrown submitted PR review.
abrown created PR review comment:
I think I got the below re-factoring correct but this comment may need to change--suggestions?
abrown requested bnjbvr for a review on PR #2898.
abrown updated PR #2898 from fix-2883
to main
.
akirilov-arm submitted PR review.
akirilov-arm created PR review comment:
Just remove the comment completely - it's no longer relevant.
abrown submitted PR review.
abrown created PR review comment:
Thanks!
abrown updated PR #2898 from fix-2883
to main
.
akirilov-arm submitted PR review.
bnjbvr submitted PR review.
abrown merged PR #2898.
Last updated: Dec 23 2024 at 12:05 UTC