Stream: git-wasmtime

Topic: wasmtime / PR #2898 cranelift: only allow vector types wi...

Wasmtime GitHub notifications bot (May 11 2021 at 18:37):

abrown opened PR #2898 from fix-2883 to main:

This fixes #2883 by restricting which types are available to the uadd_sat, sadd_sat, usub_sat, and ssub_sat IR operations.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 11 2021 at 18:39):

abrown requested bnjbvr for a review on PR #2898.

Wasmtime GitHub notifications bot (May 11 2021 at 19:34):

abrown updated PR #2898 from fix-2883 to main.

Wasmtime GitHub notifications bot (May 12 2021 at 14:11):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (May 13 2021 at 23:00):

abrown updated PR #2898 from fix-2883 to main.

Wasmtime GitHub notifications bot (May 13 2021 at 23:01):

abrown submitted PR review.

Wasmtime GitHub notifications bot (May 13 2021 at 23:01):

abrown created PR review comment:

I think I got the below re-factoring correct but this comment may need to change--suggestions?

Wasmtime GitHub notifications bot (May 13 2021 at 23:02):

abrown requested bnjbvr for a review on PR #2898.

Wasmtime GitHub notifications bot (May 14 2021 at 03:19):

abrown updated PR #2898 from fix-2883 to main.

Wasmtime GitHub notifications bot (May 14 2021 at 19:56):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (May 14 2021 at 19:56):

akirilov-arm created PR review comment:

Just remove the comment completely - it's no longer relevant.

Wasmtime GitHub notifications bot (May 14 2021 at 20:44):

abrown submitted PR review.

Wasmtime GitHub notifications bot (May 14 2021 at 20:44):

abrown created PR review comment:

Thanks!

Wasmtime GitHub notifications bot (May 14 2021 at 20:46):

abrown updated PR #2898 from fix-2883 to main.

Wasmtime GitHub notifications bot (May 14 2021 at 22:33):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (May 17 2021 at 09:08):

bnjbvr submitted PR review.

Wasmtime GitHub notifications bot (May 17 2021 at 13:54):

abrown merged PR #2898.

Last updated: Nov 22 2024 at 16:03 UTC