Stream: git-wasmtime

Topic: wasmtime / PR #2896 wasi stdio tests: increase timeout

Wasmtime GitHub notifications bot (May 11 2021 at 16:27):

pchickey opened PR #2896 from pch/wasi_stdio_test_timeout to main:

Testing for the readiness of file descriptors for reading/writing is racy in wasi-tokio because the multithreaded runtime checks using epoll on a worker thread. Tests which expect multiple file descriptors to be ready simultaneously have to bound that expectation with a timeout.

On CI, these tests execute very slowly compared to local development, so this timeout needs to be increased until we don't see CI failures anymore. It has been doubled from the timeouts observed in https://github.com/bytecodealliance/wasmtime/pull/2893

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 11 2021 at 16:29):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (May 11 2021 at 17:39):

pchickey merged PR #2896.

Last updated: Dec 23 2024 at 12:05 UTC