Stream: git-wasmtime

Topic: wasmtime / PR #2893 Remove errno dependency from cranelif...

Wasmtime GitHub notifications bot (May 11 2021 at 11:01):

bjorn3 opened PR #2893 from no_errno to main:

This removes the errno and errno-dragonfly crates from cg_clif's Cargo.lock. While the compile time win is tiny due to their size, there is no point in pulling in a dependency for something libstd already does.

Wasmtime GitHub notifications bot (May 11 2021 at 11:05):

bjorn3 edited PR #2893 from no_errno to main:

This removes the errno, errno-dragonfly and gcc crates from cg_clif's Cargo.lock. While the compile time win is tiny due to their size, there is no point in pulling in a dependency for something libstd already does.

Wasmtime GitHub notifications bot (May 11 2021 at 15:03):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (May 11 2021 at 15:03):

bnjbvr created PR Review Comment:

Can we also refactor this match using Result::map? (since the error is now untouched)

(And maybe rename map into mmap, otherwise it'll read weird: map.map(|map| {...)

Wasmtime GitHub notifications bot (May 11 2021 at 15:03):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (May 11 2021 at 15:11):

bjorn3 updated PR #2893 from no_errno to main.

Wasmtime GitHub notifications bot (May 11 2021 at 15:12):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 11 2021 at 15:12):

bjorn3 created PR Review Comment:

Done

Wasmtime GitHub notifications bot (May 11 2021 at 17:51):

cfallin merged PR #2893.

Last updated: Oct 23 2024 at 20:03 UTC