wasmtime / PR #2890 Keep track of memory regions that hav... · git-wasmtime

"Protected" in this context may mean either read-only or readable and executable (but not writable), so already_protected is a bit ambiguous. How about already_executable?

Wasmtime GitHub notifications bot (Oct 08 2021 at 17:00):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Oct 08 2021 at 17:00):

bjorn3 created PR review comment:

How about already_executable?

That would suggested that it is only for readable+executable, while this field is also for readonly. I suggested already_protected as the function that changes the memory permissions is called protect.

Wasmtime GitHub notifications bot (Oct 14 2021 at 21:15):

akirilov-arm submitted PR review.

Wasmtime GitHub notifications bot (Oct 14 2021 at 21:15):

akirilov-arm created PR review comment:

My bad, I thought that making the read-only parts of the memory readable and executable was also a valid use case, but apparently the idea is only to make transitions from readable and writable to either readable and executable or read-only.

Wasmtime GitHub notifications bot (Oct 14 2021 at 21:16):

akirilov-arm edited PR review comment.

Wasmtime GitHub notifications bot (Oct 15 2021 at 00:21):

mchesser submitted PR review.

Wasmtime GitHub notifications bot (Oct 15 2021 at 00:21):

mchesser created PR review comment:

Yeah I had the same difficulty understanding it when I came across this -- and I wasn't entirely sure whether I was missing something.

Wasmtime GitHub notifications bot (Oct 21 2021 at 23:08):

mchesser updated PR #2890 from prot-fix to main.

Wasmtime GitHub notifications bot (Oct 22 2021 at 05:05):

bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Oct 22 2021 at 12:44):

akirilov-arm merged PR #2890.

Last updated: Dec 23 2024 at 12:05 UTC