Wasmtime GitHub notifications bot (May 08 2021 at 16:19): Wasmtime GitHub notifications bot (May 08 2021 at 16:19):afonso360 opened PR #2886 from x64-i128-shift-amt to main:
Fixes #2727.
We handle the i128 cases by just ignoring the upper half of the source.
Wasmtime GitHub notifications bot (May 10 2021 at 16:43):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (May 10 2021 at 16:43):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (May 10 2021 at 16:43):cfallin created PR Review Comment:
Could we add some cases that test the masking as well? A simple way to do this might just be
v3 = uextend.i64 v2/v4 = iconcat v3, v3, i.e. extend to 64 bits then replicate the 64 bits into the low and high parts.
Wasmtime GitHub notifications bot (May 10 2021 at 17:33):afonso360 updated PR #2886 from x64-i128-shift-amt to main.
Wasmtime GitHub notifications bot (May 10 2021 at 17:34):afonso360 created PR Review Comment:
Yes, I've updated the existing test cases so that they all do that
Wasmtime GitHub notifications bot (May 10 2021 at 17:34):afonso360 submitted PR Review.
Wasmtime GitHub notifications bot (May 10 2021 at 19:50):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (May 10 2021 at 19:50):cfallin merged PR #2886.
Last updated: Oct 23 2024 at 20:03 UTC