Stream: git-wasmtime

Topic: wasmtime / PR #2884 On Windows, ignore files for which `f...

Wasmtime GitHub notifications bot (May 07 2021 at 18:36):

sunfishcode opened PR #2884 from sunfishcode/full-metadata-fun to main:

On Windows, metadata computes only partial metadata results, which don't
include what WASI needs for the inode field in readdir results. cap-std
has a full_metadata function which is able to include this extra
information, however it has more strict access requirements, so it sometimes
fails even when plain metadata would succeed.

Make WASI's readdir silently skip over files that can't be accessed by
full_metadata. These files wouldn't be openable in any other way by
WASI programs, so the only benefit of listing them would be to
let applications know that they exist. This allows it to avoid failing
and avoid returning bogus results.

This is part of a fix for bytecodealliance/cap-std#169.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 07 2021 at 19:00):

sunfishcode updated PR #2884 from sunfishcode/full-metadata-fun to main.

Wasmtime GitHub notifications bot (May 07 2021 at 19:09):

sunfishcode updated PR #2884 from sunfishcode/full-metadata-fun to main.

Wasmtime GitHub notifications bot (May 07 2021 at 19:09):

sunfishcode updated PR #2884 from sunfishcode/full-metadata-fun to main.

Wasmtime GitHub notifications bot (May 07 2021 at 21:32):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (May 07 2021 at 21:47):

sunfishcode merged PR #2884.

Last updated: Oct 23 2024 at 20:03 UTC