Stream: git-wasmtime

Topic: wasmtime / PR #2884 On Windows, ignore files for which `f...


view this post on Zulip Wasmtime GitHub notifications bot (May 07 2021 at 18:36):

sunfishcode opened PR #2884 from sunfishcode/full-metadata-fun to main:

On Windows, metadata computes only partial metadata results, which don't
include what WASI needs for the inode field in readdir results. cap-std
has a full_metadata function which is able to include this extra
information, however it has more strict access requirements, so it sometimes
fails even when plain metadata would succeed.

Make WASI's readdir silently skip over files that can't be accessed by
full_metadata. These files wouldn't be openable in any other way by
WASI programs, so the only benefit of listing them would be to
let applications know that they exist. This allows it to avoid failing
and avoid returning bogus results.

This is part of a fix for bytecodealliance/cap-std#169.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2021 at 19:00):

sunfishcode updated PR #2884 from sunfishcode/full-metadata-fun to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2021 at 19:09):

sunfishcode updated PR #2884 from sunfishcode/full-metadata-fun to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2021 at 19:09):

sunfishcode updated PR #2884 from sunfishcode/full-metadata-fun to main.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2021 at 21:32):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (May 07 2021 at 21:47):

sunfishcode merged PR #2884.


Last updated: Dec 23 2024 at 12:05 UTC