Stream: git-wasmtime

Topic: wasmtime / PR #2871 Trap handler changes to support s390x

Wasmtime GitHub notifications bot (May 03 2021 at 14:51):

uweigand opened PR #2871 from s390x-traphandler to main:

On s390x, SIGILL and SIGFPE are delivered with the PSW address
pointing after the faulting instruction, while SIGSEGV and
SIGBUS are delivered with the PSW address pointing to the
faulting instruction. In order to support this, the common
code trap handler has to distinguish between those cases.

Also, enable SIGFPE on s390x (just like on x86).

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (May 03 2021 at 15:18):

uweigand updated PR #2871 from s390x-traphandler to main.

Wasmtime GitHub notifications bot (May 03 2021 at 15:54):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (May 03 2021 at 15:54):

alexcrichton created PR Review Comment:

Is there an online link to gist here which goes into some more detail? I'm mostly just curious for my own edification!

Wasmtime GitHub notifications bot (May 03 2021 at 15:54):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (May 03 2021 at 16:31):

uweigand submitted PR Review.

Wasmtime GitHub notifications bot (May 03 2021 at 16:31):

uweigand created PR Review Comment:

That's a good question. Right now, I don't think this is documented anywhere but by reading the Linux kernel sources. This should probably be added to the ABI document. I've added an issue there as a reminder: https://github.com/IBM/s390x-abi/issues/2

Wasmtime GitHub notifications bot (May 03 2021 at 16:56):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (May 03 2021 at 16:56):

alexcrichton created PR Review Comment:

Ok, sounds reasonable to me!

Wasmtime GitHub notifications bot (May 03 2021 at 16:56):

alexcrichton merged PR #2871.

Last updated: Nov 22 2024 at 17:03 UTC