Stream: git-wasmtime

Topic: wasmtime / PR #2866 debug: Avoid underflow when scanning ...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 30 2021 at 15:31):

bnjbvr opened PR #2866 from debug-overflow to main:

I don't really know what I'm doing here, but bear with me... This landing pad bytes scanning assumes at least 2 bytes in the given buffer, but in a local test case I was trying against, the buffer was empty, so 0 bytes, so the subtract would underflow. Just adding this guard seems to make it work-ish -- I don't get full variable inspection power, but I expect that this is unrelated to my change.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2021 at 16:58):

alexcrichton merged PR #2866.


Last updated: Dec 23 2024 at 13:07 UTC