Stream: git-wasmtime

Topic: wasmtime / PR #2865 Expose new `JITModule::read_got_entry...

Wasmtime GitHub notifications bot (Apr 29 2021 at 08:36):

eggyal edited PR #2865 from expose_get_got_address to main.

Wasmtime GitHub notifications bot (Apr 29 2021 at 08:39):

eggyal edited PR #2865 from expose_get_got_address to main:

This hasn't been discussed in a wasmtime issue, but (together with #2786) it's needed it for bjorn3/rustc_codegen_cranelift#1166.

It exposes ~JITModule::get_got_address~ a new JITModule::read_got_entry function so that, when jitting lazily, cranelift users can inspect the GOT to determine whether a given function's entry is still their shim trampoline or not (and therefore whether the function has already been jitted). This prevents the function from being jitted differently from simultaneous requests arising from different threads.

No test cases added~, because exposing a function obviously doesn't change any behaviour~.

Sorry, I don't know who would be an appropriate reviewer for this.

Wasmtime GitHub notifications bot (Apr 29 2021 at 08:39):

eggyal edited PR #2865 from expose_get_got_address to main:

This hasn't been discussed in a wasmtime issue, but (together with #2786) it's needed it for bjorn3/rustc_codegen_cranelift#1166.

It exposes ~JITModule::get_got_address~ a new JITModule::read_got_entry function so that, when jitting lazily, cranelift users can inspect the GOT to determine whether a given function's entry is still their shim trampoline or not (and therefore whether the function has already been jitted). This prevents the function from being jitted differently from simultaneous requests arising from different threads.

No test cases added, ~because exposing a function obviously doesn't change any behaviour~.

Sorry, I don't know who would be an appropriate reviewer for this.

Wasmtime GitHub notifications bot (May 04 2021 at 11:36):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (May 04 2021 at 16:34):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (May 04 2021 at 18:30):

cfallin merged PR #2865.

Last updated: Dec 23 2024 at 12:05 UTC