Stream: git-wasmtime

Topic: wasmtime / PR #2863 Bring back per-thread lazy initializa...

Wasmtime GitHub notifications bot (Apr 28 2021 at 00:45):

alexcrichton opened PR #2863 from more-tls to main:

Platforms Wasmtime supports may have per-thread initialization that
needs to run before WebAssembly. For example Unix needs to setup a
sigaltstack and macOS needs to set up mach ports. In #2757 this
per-thread setup was moved out of the invocation of a wasm function,
relying on the lack of Send for Store to initialize the thread at Store
creation time and never worry about it later.

This conflicted with wasmtime's desired multithreading story so a new
Store::notify_switched_thread was added to
explicitly indicate a Store has moved to another thread (if it unsafely
did so).

It turns out though that it's not always easy to determine when a
Store moves to a new thread. For example the Go bindings for Wasmtime
are generally unaware when a goroutine switches OS threads. This led to
https://github.com/bytecodealliance/wasmtime-go/issues/74 where a SIGILL
was left uncaught, making it appear that traps aren't working properly.

This commit revisits the decision in #2757 and moves per-thread
initialization back into the path of calling into WebAssembly. This is
differently from before, though, where there's still only one TLS access
on the path of calling into WebAssembly, unlike before where it was a
separate access. This allows us to get the speed benefits of #2757 as
well as the flexibility benefits of not having to explicitly move a
store between threads.

With this new ability this commit deletes the recently added
Store::notify_switched_thread method since it's no longer necessary.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 28 2021 at 14:27):

alexcrichton updated PR #2863 from more-tls to main.

Wasmtime GitHub notifications bot (Apr 28 2021 at 16:38):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 28 2021 at 17:08):

alexcrichton merged PR #2863.

Last updated: Dec 23 2024 at 12:05 UTC