Wasmtime GitHub notifications bot (Apr 21 2021 at 12:20): Wasmtime GitHub notifications bot (Apr 21 2021 at 12:20):uweigand opened PR #2854 from debug-endian to main:
This fixes some hard-coded assumptions in the debug crate that
the native ELF files being accessed are little-endian; specifically
in create_gdbjit_image as well as in emit_dwarf.In addition, data in WebAssembly memory always uses little-endian
byte order. Therefore, if the native architecture is big-endian,
all references to base types need to be marked as little-endian
using the DW_AT_endianity attribute, so that the debugger will
be able to correctly access them.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 27 2021 at 17:27):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 27 2021 at 17:27):cfallin merged PR #2854.
Last updated: Nov 22 2024 at 17:03 UTC