Wasmtime GitHub notifications bot (Apr 20 2021 at 20:37): Wasmtime GitHub notifications bot (Apr 20 2021 at 20:37):alexcrichton opened PR #2851 from fix-declared-element to main:
Now that we're using "possibly exported" as an impactful decision for
codegen (which trampolines to generate and which ABI a function has)
it's important that we calculate this property of a wasm function
correctly! Previously Wasmtime forgot to processed "declared" elements
in apart from active/passive element segments, but this updates Wasmtime
to ensure that these entries are processed and all the functions
contained within are flagged as "possibly exported".Closes #2850
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 20 2021 at 20:38):alexcrichton updated PR #2851 from fix-declared-element to main.
Wasmtime GitHub notifications bot (Apr 20 2021 at 20:38):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Apr 20 2021 at 21:52):alexcrichton merged PR #2851.
Last updated: Dec 23 2024 at 12:05 UTC