Wasmtime GitHub notifications bot (Apr 15 2021 at 18:39): Wasmtime GitHub notifications bot (Apr 15 2021 at 18:39):uweigand opened PR #2843 from spillslot-fix to main:
PR 2840 changed the store_spillslot routine to always store
integer registers in full word size to a spill slot. However,
the load_spillslot routine was not updated, which may causes
the contents to be reloaded in a different type. On big-endian
systems this will fetch wrong data.Fixed by using the same type override in load_spillslot.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 15 2021 at 18:40):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 15 2021 at 19:39):uweigand updated PR #2843 from spillslot-fix to main.
Wasmtime GitHub notifications bot (Apr 15 2021 at 20:28):cfallin merged PR #2843.
Last updated: Dec 23 2024 at 12:05 UTC