Wasmtime GitHub notifications bot (Apr 14 2021 at 12:22): Wasmtime GitHub notifications bot (Apr 14 2021 at 12:22):uweigand opened PR #2838 from optionalfp to main:
The patch extends the unwinder to support targets that do not need
to use a dedicated frame pointer register. Specifically, the
changes include:
Change the "fp" routine in the RegisterMapper to return an
optional frame pointer regsiter via Option<Register>.On targets that choose to not define a FP register via the above
routine, the UnwindInst::DefineNewFrame operation no longer switches
the CFA to be defined in terms of the FP. (The operation still can
be used to define the location of the clobber area.)In addition, on targets that choose not to define a FP register, the
UnwindInst::PushFrameRegs operation is not supported.There is a new operation UnwindInst::StackAlloc that needs to be
called on targets without FP whenever the stack pointer is updated.
This caused the CFA offset to be adjusted accordingly. (On
targets with FP this operation is a no-op.)<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 14 2021 at 14:26):uweigand updated PR #2838 from optionalfp to main.
Wasmtime GitHub notifications bot (Apr 14 2021 at 17:58):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 14 2021 at 17:58):cfallin merged PR #2838.
Last updated: Nov 22 2024 at 17:03 UTC