Wasmtime GitHub notifications bot (Apr 14 2021 at 12:21): Wasmtime GitHub notifications bot (Apr 14 2021 at 12:21):uweigand opened PR #2836 from framesizefix to main:
After the unwind rework (commit 2d5db92a) the space used to save
clobbered registers now lies between the nominal SP and the FP.
Therefore, the size of that space should now be included in the
frame size as reported by frame_size(), since this value is used
to compute the nominal_sp_to_fp offset.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 14 2021 at 17:56):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 14 2021 at 19:19):cfallin merged PR #2836.
Last updated: Nov 22 2024 at 16:03 UTC