abrown opened PR #2833 from 2826
to main
:
In #2826, @bjorn3 found an issue relating to
Inst::store
--not all types, e.g.I16
, were supported. There is no reasonInst::store
shouldn't have this functionality: the emission ofMovRM
already supports this. @bjorn3, can you provide a CLIF test to trigger the error you found?Also, to make troubleshooting easier in the future, I re-factored
lower.rs
to useInst::store
in all the places it previously usedInst::mov_r_m
. This should make things easier to troubleshoot: only one function,Inst::store
, now understands what move instruction is needed for each different CLIF type.
abrown requested cfallin for a review on PR #2833.
cfallin submitted PR Review.
cfallin merged PR #2833.
Last updated: Dec 23 2024 at 12:05 UTC