Stream: git-wasmtime

Topic: wasmtime / PR #2833 x64: fix Inst::store to understand al...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2021 at 20:19):

abrown opened PR #2833 from 2826 to main:

In #2826, @bjorn3 found an issue relating to Inst::store--not all types, e.g. I16, were supported. There is no reason Inst::store shouldn't have this functionality: the emission of MovRM already supports this. @bjorn3, can you provide a CLIF test to trigger the error you found?

Also, to make troubleshooting easier in the future, I re-factored lower.rs to use Inst::store in all the places it previously used Inst::mov_r_m. This should make things easier to troubleshoot: only one function, Inst::store, now understands what move instruction is needed for each different CLIF type.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2021 at 20:24):

abrown requested cfallin for a review on PR #2833.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2021 at 22:36):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2021 at 22:36):

cfallin merged PR #2833.

Last updated: Nov 22 2024 at 17:03 UTC