Stream: git-wasmtime

Topic: wasmtime / PR #2832 wasi-common: optional support for run...

Wasmtime GitHub notifications bot (Apr 13 2021 at 19:43):

pchickey edited PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 00:15):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 00:50):

pchickey edited PR #2832 from pch/wiggle_sync_shimming to main:

wasmtime-wiggle now supports running async methods via a dummy executor, in order to support running synchronous wasi-common implementations.

wasi-common now uses an async_trait for its WasiSched trait methods. This requires that poll_oneoff and sched_yield become async methods as well.

wasi-cap-std-sync stays the same, modulo the code golf required to add async in front of some fns.

wasi-cap-std-async is introduced, and for now it is exactly the same as wasi-cap-std-sync except that sleep and sched_yield are implemented via tokio. Poll is for now unsupported! This needs to be fixed in order to merge.

wasmtime-wasi now exports two different Wasis - one under sync:: and one under async_::. This is a breaking API change. Almost all users will want to use the one under sync::. Should I maybe re-export that at the top level by default?

A new example shows using wasmtime_wasi::async_::Wasi under tokio.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 14 2021 at 00:51):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 00:53):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 00:54):

pchickey edited PR #2832 from pch/wiggle_sync_shimming to main:

wasmtime-wiggle now supports running async methods via a dummy executor, in order to support running synchronous wasi-common implementations.

wasi-common now uses an async_trait for its WasiSched trait methods. This requires that poll_oneoff and sched_yield become async methods as well.

wasi-cap-std-sync stays the same, modulo the code golf required to add async in front of some fns.

wasi-cap-std-async is introduced, and for now it is exactly the same as wasi-cap-std-sync except that sleep and sched_yield are implemented via tokio. Poll is for now unsupported! This needs to be fixed in order to merge.

wasmtime-wasi now exports two different Wasis - one under sync:: and one under async_::. This is a breaking API change. Almost all users will want to use the one under sync::. Should I maybe re-export that at the top level by default?

A new example shows using wasmtime_wasi::async_::Wasi under tokio. It incorporates a lot of comments @alexcrichton wrote previously. https://github.com/bytecodealliance/wasmtime/blob/759019811ef5b28a99ea56ec640102fb27a2f110/examples/tokio/main.rs

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 14 2021 at 15:38):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 16:54):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 22:43):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 23:07):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 23:17):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 14 2021 at 23:55):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 15 2021 at 18:39):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 15 2021 at 21:50):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 15 2021 at 23:00):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 19 2021 at 23:01):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 21 2021 at 17:37):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 23 2021 at 19:33):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 26 2021 at 21:43):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 28 2021 at 19:00):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (Apr 29 2021 at 23:50):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 01 2021 at 22:40):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 04 2021 at 18:29):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 04 2021 at 21:16):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 04 2021 at 21:28):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 18:01):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 18:17):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 18:24):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 19:01):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 20:09):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 20:32):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 21:57):

pchickey updated PR #2832 from pch/wiggle_sync_shimming to main.

Wasmtime GitHub notifications bot (May 05 2021 at 23:18):

pchickey has marked PR #2832 as ready for review.

Last updated: Dec 23 2024 at 13:07 UTC