Wasmtime GitHub notifications bot (Apr 13 2021 at 18:18): Wasmtime GitHub notifications bot (Apr 13 2021 at 18:18):cfallin opened PR #2830 from pin-nightly to main:
We seem to be seeing some CI failures in various PRs today due to new warnings added to nightly Rust.
It seems reasonable to me to pin the nightly version we use on CI, and periodically update this, so that if breakages are going to happen then they happen in a single place when we update the pinned version. This also insulates us somewhat from occasional bugs that slip into nightlies. (We had a similar strategy for the new-x64-backend tests for a bit, pinning to a particular nightly version.)
In particular, for the latest failures, it looks like a nightly bug: the compiler is interpreting
_-args as patterns rather than ignored args and then issuing warnings-as-errors to use underscores instead (!). The only immediate fix is to use a different nightly, I think.I can see the argument for the other approach, though, that we want to guarantee as best we can that we work with the latest nightly and fix issues immediately as they arise (this is analogous to the usual rolling release vs fixed release debate I guess). Happy to discuss!
(I chose a one-day-old nightly for this PR -- let's s see if this works on CI...)
Wasmtime GitHub notifications bot (Apr 13 2021 at 18:18):cfallin requested pchickey and peterhuene for a review on PR #2830.
Wasmtime GitHub notifications bot (Apr 13 2021 at 18:18):cfallin requested pchickey and peterhuene for a review on PR #2830.
Wasmtime GitHub notifications bot (Apr 13 2021 at 18:19):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Apr 13 2021 at 18:38):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Apr 13 2021 at 19:06):cfallin merged PR #2830.
Last updated: Nov 22 2024 at 16:03 UTC