alexcrichton opened PR #2821 from faster-vmoffsets
to main
:
This commit updates the implementation of
VMOffsets
to frontload all
checked arithmetic on construction of theVMOffsets
which allows
eliding all checked arithmetic when accessing the fields ofVMOffsets
.
For testing and such this adds a new constructor as well from a new
VMOffsetsFields
structure which is a clone of the old definition.This should help speed up some profile hot spots I've been seeing where
with all the checked arithmetic on field sizes this was slowing down the
various accessors during instantiation (which usesVMOffsets
to
initialize various fields of theVMContext
).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
alexcrichton updated PR #2821 from faster-vmoffsets
to main
.
peterhuene submitted PR Review.
fitzgen merged PR #2821.
Last updated: Dec 23 2024 at 12:05 UTC