Stream: git-wasmtime

Topic: wasmtime / PR #2816 Don't hash for the cache if it's disa...

Wasmtime GitHub notifications bot (Apr 08 2021 at 15:36):

alexcrichton opened PR #2816 from no-sha to main:

This fixes an issue where even if the wasmtime cache was disabled we're
still calculating the sha256 of modules for the hash key. This hash
was then simply discarded if the cache was disabled!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 08 2021 at 16:35):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Apr 08 2021 at 16:48):

alexcrichton merged PR #2816.

Last updated: Nov 22 2024 at 16:03 UTC