Stream: git-wasmtime

Topic: wasmtime / PR #2812 Document guidance around multithreadi...

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:30):

alexcrichton opened PR #2812 from doc-multithreading to main:

This commit writes a page of documentation for the Wasmtime book to
serve as guidance for embedders looking to add multithreading with
Wasmtime support. As always with any safe Rust API this reading is
optional because you can't mis-use Wasmtime without unsafe, but I'm
hoping that this documentation can serve as a point of reference for
folks who want to add multithreading but are confused/annoyed that
Wasmtime's types do not implement the Send and Sync traits.

Closes #793

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:49):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:49):

peterhuene created PR Review Comment:

  This will ensure that no one request entirely hogs a thread executing

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:49):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:51):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:51):

peterhuene created PR Review Comment:

* If absolutely required, Wasmtime is engineered such that it is dynamically safe

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:51):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:51):

peterhuene created PR Review Comment:

These types, as the traits imply, are safe to send and share across threads. Note

Wasmtime GitHub notifications bot (Apr 07 2021 at 20:54):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Apr 07 2021 at 21:05):

alexcrichton updated PR #2812 from doc-multithreading to main.

Wasmtime GitHub notifications bot (Apr 07 2021 at 21:34):

alexcrichton merged PR #2812.

Last updated: Dec 23 2024 at 12:05 UTC