Wasmtime GitHub notifications bot (Apr 06 2021 at 14:27): Wasmtime GitHub notifications bot (Apr 06 2021 at 14:27):bnjbvr opened PR #2809 from mac-aarch64-test-tweaks to main:
some tests don't pass because of bad interactions with the system's
libunwind; ignore them for now.the page size on mac aarch64 is 16K, not 4K; tweak some tests which
were expecting 4K or multiples of 4K pages to use a multiple of host page size
instead.a cranelift-native test needed an update for the new calling convention.
This also documents the test failures on mac aarch64. I am pretty sure I saw more a few weeks ago, and they've been fixed since then, so congratulations to the team :smile:
With these changes, the test suite as run from the CI "test" step passes on my Mac M1.
Wasmtime GitHub notifications bot (Apr 06 2021 at 14:39):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Apr 06 2021 at 14:39):bjorn3 created PR Review Comment:
Maybe move this
if cfg!(above theif cfg!(any(unix, ...?
Wasmtime GitHub notifications bot (Apr 06 2021 at 15:32):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Apr 06 2021 at 15:32):bnjbvr created PR Review Comment:
yep, and it's not even correct for macos x64, will fix.
Wasmtime GitHub notifications bot (Apr 06 2021 at 15:38):bnjbvr updated PR #2809 from mac-aarch64-test-tweaks to main.
Wasmtime GitHub notifications bot (Apr 06 2021 at 18:55):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Apr 06 2021 at 19:10):cfallin created PR Review Comment:
s/instance/instance struct/? (I read it the other way and was puzzled briefly)
Wasmtime GitHub notifications bot (Apr 06 2021 at 19:10):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Apr 07 2021 at 08:54):bnjbvr updated PR #2809 from mac-aarch64-test-tweaks to main.
Wasmtime GitHub notifications bot (Apr 07 2021 at 08:55):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Apr 07 2021 at 08:55):bnjbvr created PR Review Comment:
done!
Wasmtime GitHub notifications bot (Apr 07 2021 at 12:54):bnjbvr merged PR #2809.
Last updated: Nov 22 2024 at 17:03 UTC