bnjbvr opened PR #2809 from mac-aarch64-test-tweaks
to main
:
some tests don't pass because of bad interactions with the system's
libunwind; ignore them for now.the page size on mac aarch64 is 16K, not 4K; tweak some tests which
were expecting 4K or multiples of 4K pages to use a multiple of host page size
instead.a cranelift-native test needed an update for the new calling convention.
This also documents the test failures on mac aarch64. I am pretty sure I saw more a few weeks ago, and they've been fixed since then, so congratulations to the team :smile:
With these changes, the test suite as run from the CI "test" step passes on my Mac M1.
bjorn3 submitted PR Review.
bjorn3 created PR Review Comment:
Maybe move this
if cfg!(
above theif cfg!(any(unix, ...
?
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
yep, and it's not even correct for macos x64, will fix.
bnjbvr updated PR #2809 from mac-aarch64-test-tweaks
to main
.
alexcrichton submitted PR Review.
cfallin created PR Review Comment:
s/instance/instance struct/? (I read it the other way and was puzzled briefly)
cfallin submitted PR Review.
bnjbvr updated PR #2809 from mac-aarch64-test-tweaks
to main
.
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
done!
bnjbvr merged PR #2809.
Last updated: Dec 23 2024 at 13:07 UTC