Stream: git-wasmtime

Topic: wasmtime / PR #2799 x64: refactor REX-specific encoding m...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:17):

abrown opened PR #2799 from inst-format to main:

In preparation for adding new encoding modes to the x64 backend (e.g. VEX,
EVEX), this change moves all of the current instruction encoding functions to
encodings::rex. This refactor does not change any logic.
Please enter the commit message for your changes. Lines starting

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:17):

abrown requested bnjbvr for a review on PR #2799.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:17):

abrown requested cfallin and bnjbvr for a review on PR #2799.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:18):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:18):

abrown created PR Review Comment:

Not sure about what visibility level is best for this module...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:22):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:22):

abrown created PR Review Comment:

In a future change, I would like to:

Any thoughts for or against this?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:23):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:23):

abrown created PR Review Comment:

Eventually other ways to encode instruction formats would get exposed here.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:24):

abrown edited PR #2799 from inst-format to main:

In preparation for adding new encoding modes to the x64 backend (e.g. VEX,
EVEX), this change moves all of the current instruction encoding functions to
encodings::rex. This refactor does not change any logic.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:24):

abrown updated PR #2799 from inst-format to main.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 00:25):

abrown requested cfallin, bnjbvr and julian-seward1 for a review on PR #2799.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 17:39):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 17:39):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 17:39):

cfallin created PR Review Comment:

I think crate-public is good for now. We should probably reconsider some of the other pub submodules, to be honest; IMHO we expose too much implementation already; but that's out-of-scope here :-)

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 17:39):

cfallin created PR Review Comment:

+1 to both of these!

In particular to the first point: there is really an x86-64 assembler library begging to escape from this module -- it is "incomplete" in the sense that it only implements the instructions we actually need, but maybe it could be useful for other folks in the Rust world as well, eventually.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 18:17):

abrown merged PR #2799.


Last updated: Dec 23 2024 at 13:07 UTC