Stream: git-wasmtime

Topic: wasmtime / PR #2790 wiggle::async_trait is defined as asy...

Wasmtime GitHub notifications bot (Mar 29 2021 at 17:06):

pchickey opened PR #2790 from pch/wiggle_async_trait_reexport to main:

async methods used by wiggle currently need to Not have the Send
constraint, so rather than make all use sites pass the argument
to the re-exported async_trait macro, define a new macro that
applies the argument.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 29 2021 at 17:06):

pchickey requested alexcrichton for a review on PR #2790.

Wasmtime GitHub notifications bot (Mar 29 2021 at 17:40):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 29 2021 at 18:03):

pchickey merged PR #2790.

Last updated: Dec 23 2024 at 12:05 UTC