Stream: git-wasmtime

Topic: wasmtime / PR #2789 Remove the type-driven ability for du...

Wasmtime GitHub notifications bot (Mar 29 2021 at 16:04):

alexcrichton opened PR #2789 from better-linker-errors to main:

When Linker was first created it was attempted to be created with the
ability to instantiate any wasm modules, including those with duplicate
import strings of different types. In an effort to support this a
Linker supports defining the same names twice so long as they're
defined with differently-typed values.

This ended up causing wast testsuite failures module linking is enabled,
however, because the wrong error message is returned. While it would be
possible to fix this there's already the possibility for confusing error
messages today due to the Linker trying to take on this type-level
complexity. In a way this is yet-another type checker for wasm imports,
but sort of a bad one because it only supports things like
globals/functions, and otherwise you can only define one Memory, for
example, with a particular name.

This commit completely removes this feature from Linker to simplify
the implementation and make error messages more straightforward. This
means that any error message coming from a Linker is purely "this
thing wasn't defined" rather than a hybrid of "maybe the types didn't
match?". I think this also better aligns with the direction that we see
conventional wasm modules going which is that duplicate imports are not
ever present.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 29 2021 at 20:44):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 29 2021 at 22:26):

alexcrichton merged PR #2789.

Last updated: Dec 23 2024 at 12:05 UTC