Wasmtime GitHub notifications bot (Mar 26 2021 at 22:34): Wasmtime GitHub notifications bot (Mar 26 2021 at 22:34):pchickey opened PR #2782 from pch/wiggle_tracing_span_fix to main:
The code I wrote here prior was incorrect: a span is present at the
level specified and below; previously I thought it was present at the
level specified and above. So, previously, a TRACE-level event inside
this span would be associated with the module and function name provided
here. Now all events inside this span should be associated with it.Thank you @iximeow for teaching me this!
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 26 2021 at 22:34):pchickey requested iximeow for a review on PR #2782.
Wasmtime GitHub notifications bot (Mar 27 2021 at 01:48):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 28 2021 at 22:04):pchickey merged PR #2782.
Last updated: Dec 23 2024 at 12:05 UTC