Stream: git-wasmtime

Topic: wasmtime / PR #2778 fuzz: Allow incompatible import types...

Wasmtime GitHub notifications bot (Mar 26 2021 at 15:33):

alexcrichton opened PR #2778 from fix-fuzz to main:

Yesterday fuzzing was switched to using a Linker to improve coverage
when using module linking since we can fake instance imports with
definitions of each individual item. Using a Linker, however, means
that we can't necessarily instantiate all modules, such as

(module
  (import "" "" (memory (;0;) 0 1))
  (import "" "" (memory (;1;) 2)))

As a result this just allows these sorts of "incompatible import type"
errors when fuzzing to not trigger crashes.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 26 2021 at 17:08):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Mar 26 2021 at 17:08):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Mar 26 2021 at 17:08):

fitzgen created PR Review Comment:

We might want to consolidate these so that we only to_string once, which should help our fuzzing throughput a little bit.

Wasmtime GitHub notifications bot (Mar 26 2021 at 18:27):

alexcrichton updated PR #2778 from fix-fuzz to main.

Wasmtime GitHub notifications bot (Mar 26 2021 at 18:28):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 26 2021 at 18:28):

alexcrichton created PR Review Comment:

:+1:

Wasmtime GitHub notifications bot (Mar 26 2021 at 19:38):

alexcrichton merged PR #2778.

Last updated: Nov 22 2024 at 16:03 UTC