Stream: git-wasmtime

Topic: wasmtime / PR #2778 fuzz: Allow incompatible import types...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 15:33):

alexcrichton opened PR #2778 from fix-fuzz to main:

Yesterday fuzzing was switched to using a Linker to improve coverage
when using module linking since we can fake instance imports with
definitions of each individual item. Using a Linker, however, means
that we can't necessarily instantiate all modules, such as

(module
  (import "" "" (memory (;0;) 0 1))
  (import "" "" (memory (;1;) 2)))

As a result this just allows these sorts of "incompatible import type"
errors when fuzzing to not trigger crashes.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 17:08):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 17:08):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 17:08):

fitzgen created PR Review Comment:

We might want to consolidate these so that we only to_string once, which should help our fuzzing throughput a little bit.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 18:27):

alexcrichton updated PR #2778 from fix-fuzz to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 18:28):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 18:28):

alexcrichton created PR Review Comment:

:+1:

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 19:38):

alexcrichton merged PR #2778.


Last updated: Dec 23 2024 at 12:05 UTC