Wasmtime GitHub notifications bot (Mar 25 2021 at 20:02): Wasmtime GitHub notifications bot (Mar 25 2021 at 20:02):alexcrichton opened PR #2772 from dedupe-function-signatures to main:
Currently wasmtime will generate a
SignatureIndex-per-type in the
module itself, even if the module itself declares the same type multiple
times. To make matters worse if the same type is declared across
multiple modules used in a module-linking-using-module then the
signature will be recorded each time it's declared.This commit adds a simple map to module translation to deduplicate these
function types. This should improve the performance of module-linking
graphs where the same function type may be declared in a number of
modules. For modules that don't use module linking this adds an extra
map that's not used too often, but the time spent managing it should be
dwarfed by other compile tasks.
Wasmtime GitHub notifications bot (Mar 25 2021 at 20:12):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Mar 25 2021 at 23:44):alexcrichton merged PR #2772.
Last updated: Nov 22 2024 at 17:03 UTC