Stream: git-wasmtime

Topic: wasmtime / PR #2761 wasmtime-wiggle: make it possible to ...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 02:01):

pchickey opened PR #2761 from pch/wasmtime_wiggle_alias_host_funcs to main:

This addition to wasmtime-wiggle makes it possible to add a function to a Config under an arbitrary name.

Embeddings that allow Wasm functions defined by wiggle to be imported under additional names (for example, for legacy compatibility) can do so by writing their own Linker invocation, but functions were added to a Config under only the name specified by the witx file. Now, in addition to the default add_to_config behavior, you can add_<functionname>_to_config(&mut config, module: &str, field: &str) as well.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 02:01):

pchickey requested alexcrichton for a review on PR #2761.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 14:17):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 14:17):

alexcrichton created PR Review Comment:

stray debugging printlns?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 14:17):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 16:04):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 16:04):

pchickey created PR Review Comment:

oops thanks

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 17:44):

pchickey updated PR #2761 from pch/wasmtime_wiggle_alias_host_funcs to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 25 2021 at 20:31):

alexcrichton merged PR #2761.


Last updated: Dec 23 2024 at 12:05 UTC