Stream: git-wasmtime

Topic: wasmtime / PR #2760 wiggle: delete GuestErrorConversion, ...

Wasmtime GitHub notifications bot (Mar 24 2021 at 05:23):

pchickey opened PR #2760 from pch/wiggle_error_reporting to main:

With the latest renovation to witx, wiggle no longer generates code that calls the GuestErrorConversion trait to transform a GuestError into the function's error type. Instead, wiggle will trap execution if a GuestError is thrown in generated code.

This PR removes generation of the GuestErrorConversion trait. Users can delete their impls of it - they are dead code.

I also fixed up the Display impl of the GuestError::InFunc variant to be more useful, and deleted GuestError::InDataField because it was also dead code.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 24 2021 at 05:23):

pchickey requested alexcrichton for a review on PR #2760.

Wasmtime GitHub notifications bot (Mar 24 2021 at 14:06):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 24 2021 at 17:39):

pchickey updated PR #2760 from pch/wiggle_error_reporting to main.

Wasmtime GitHub notifications bot (Mar 24 2021 at 18:19):

pchickey updated PR #2760 from pch/wiggle_error_reporting to main.

Wasmtime GitHub notifications bot (Mar 24 2021 at 18:37):

pchickey updated PR #2760 from pch/wiggle_error_reporting to main.

Wasmtime GitHub notifications bot (Mar 24 2021 at 20:39):

pchickey merged PR #2760.

Last updated: Dec 23 2024 at 13:07 UTC