Wasmtime GitHub notifications bot (Mar 23 2021 at 21:49): Wasmtime GitHub notifications bot (Mar 23 2021 at 21:49):alexcrichton opened PR #2759 from fast-call2 to main:
This continues https://github.com/bytecodealliance/wasmtime/pull/2757 a bit more by optimizing calls into WebAssembly. The first commit should affect all platforms, but is only a minor speedup. The second commit is a macOS-specific improvement but is a very large improvement for macOS. I believe after this all platforms should be again performing roughly on-par with one another.
Wasmtime GitHub notifications bot (Mar 24 2021 at 00:36):alexcrichton updated PR #2759 from fast-call2 to main.
Wasmtime GitHub notifications bot (Mar 24 2021 at 10:57):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2021 at 10:57):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2021 at 10:57):bnjbvr created PR Review Comment:
nit: unregisters
Wasmtime GitHub notifications bot (Mar 24 2021 at 10:57):bnjbvr created PR Review Comment:
Missing comment here.
Wasmtime GitHub notifications bot (Mar 24 2021 at 10:57):bnjbvr created PR Review Comment:
There was a check in the unix implementation that the
jmp_bufcould be set to 1 (meaning a custom signal handler has run and the trap handler should return early). Is it not necessary anymore?
Wasmtime GitHub notifications bot (Mar 24 2021 at 10:57):bnjbvr created PR Review Comment:
Missing comment here?
Wasmtime GitHub notifications bot (Mar 24 2021 at 10:57):bnjbvr created PR Review Comment:
Can we check that the start is the same? And as a poor man's check for function, that the
functions.size()match?
Wasmtime GitHub notifications bot (Mar 24 2021 at 14:14):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2021 at 14:14):alexcrichton created PR Review Comment:
Ah yeah I realized that it was no longer necessary since we don't run the custom trap handler on macOS, it's only run on Unix and Windows now.
Wasmtime GitHub notifications bot (Mar 24 2021 at 15:22):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2021 at 15:22):alexcrichton created PR Review Comment:
Weird I remember writing docs here... I guess I accidentally blew them away!
Wasmtime GitHub notifications bot (Mar 24 2021 at 15:24):alexcrichton updated PR #2759 from fast-call2 to main.
Wasmtime GitHub notifications bot (Mar 24 2021 at 16:41):alexcrichton merged PR #2759.
Last updated: Oct 23 2024 at 20:03 UTC