Stream: git-wasmtime

Topic: wasmtime / PR #2753 Support "sleep" forms of `poll_oneoff`.

Wasmtime GitHub notifications bot (Mar 22 2021 at 16:17):

sunfishcode opened PR #2753 from sunfishcode/sleep to main:

Add support for poll_oneoff calls which just sleep on a relative
timeout. This fixes a bug handling code compiled with WASI libc's sleep
family of functions, which call poll_oneoff with a CLOCK_REALTIME
timer, which wasn't previously implemented.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 22 2021 at 16:17):

sunfishcode requested pchickey for a review on PR #2753.

Wasmtime GitHub notifications bot (Mar 22 2021 at 17:45):

sunfishcode updated PR #2753 from sunfishcode/sleep to main.

Wasmtime GitHub notifications bot (Mar 22 2021 at 18:02):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Mar 22 2021 at 18:02):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Mar 22 2021 at 18:02):

pchickey created PR Review Comment:

This special case is a good idea, but i'd like for the thread::sleep call to instead be dispatched into self.sched.sleep so that wasi-common consumers can control that implementation by either using the default wasi-cap-std-sync impls or creating their own.

Wasmtime GitHub notifications bot (Mar 22 2021 at 18:24):

sunfishcode updated PR #2753 from sunfishcode/sleep to main.

Wasmtime GitHub notifications bot (Mar 22 2021 at 18:26):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 22 2021 at 18:26):

sunfishcode created PR Review Comment:

Sounds good; I've now added a sleep function to WasiSched and added impls for it.

Wasmtime GitHub notifications bot (Mar 22 2021 at 18:39):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Mar 22 2021 at 19:50):

sunfishcode merged PR #2753.

Last updated: Nov 22 2024 at 16:03 UTC