Stream: git-wasmtime

Topic: wasmtime / PR #2753 Support "sleep" forms of `poll_oneoff`.


view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 16:17):

sunfishcode opened PR #2753 from sunfishcode/sleep to main:

Add support for poll_oneoff calls which just sleep on a relative
timeout. This fixes a bug handling code compiled with WASI libc's sleep
family of functions, which call poll_oneoff with a CLOCK_REALTIME
timer, which wasn't previously implemented.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 16:17):

sunfishcode requested pchickey for a review on PR #2753.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 17:45):

sunfishcode updated PR #2753 from sunfishcode/sleep to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 18:02):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 18:02):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 18:02):

pchickey created PR Review Comment:

This special case is a good idea, but i'd like for the thread::sleep call to instead be dispatched into self.sched.sleep so that wasi-common consumers can control that implementation by either using the default wasi-cap-std-sync impls or creating their own.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 18:24):

sunfishcode updated PR #2753 from sunfishcode/sleep to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 18:26):

sunfishcode submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 18:26):

sunfishcode created PR Review Comment:

Sounds good; I've now added a sleep function to WasiSched and added impls for it.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 18:39):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2021 at 19:50):

sunfishcode merged PR #2753.


Last updated: Dec 23 2024 at 12:05 UTC