Wasmtime GitHub notifications bot (Mar 10 2021 at 08:01): Wasmtime GitHub notifications bot (Mar 10 2021 at 08:01):cfallin opened PR #2718 from new-backend to main:
(Note 1: This PR depends on #2710 and includes its commits for CI purposes for now.)
(Note 2: I plan to write an RFC to more fully describe and get consensus on the process of switching over. This is mostly a PR for CI-experimentation and to get some data/confirmation on what's actually left to be done.)
This PR switches the default backend on x86, for both the
cranelift-codegencrate and for Wasmtime, to the new
(MachInst-style,VCode-based) backend that has been under
development and testing for some time now.The old backend is still available by default in builds with the
old-x86-backendfeature, or by requestingBackendVariant::Legacy
from the appropriate APIs.As part of that switch, it adds some more runtime-configurable plumbing
to the testing infrastructure so that tests can be run using the
appropriate backend.clif-util testis now capable of parsing a
backend selector option from filetests and instantiating the correct
backend.I has been updated so that the old x86 backend continues to run its
tests, just as we used to run the new x64 backend separately.At some point, we will remove the old x86 backend entirely, once we are
satisfied that the new backend has not caused any unforeseen issues and
we do not need to revert.
Wasmtime GitHub notifications bot (Mar 10 2021 at 08:02):cfallin has marked PR #2718 as ready for review.
Wasmtime GitHub notifications bot (Mar 10 2021 at 08:04):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 08:16):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 08:30):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2021 at 08:30):bjorn3 created PR Review Comment:
Wasmtime GitHub notifications bot (Mar 10 2021 at 08:31):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2021 at 08:31):bjorn3 created PR Review Comment:
Wasmtime GitHub notifications bot (Mar 10 2021 at 17:15):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 17:16):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 17:16):cfallin created PR Review Comment:
Done, thanks.
Wasmtime GitHub notifications bot (Mar 10 2021 at 17:16):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2021 at 17:17):cfallin created PR Review Comment:
Done.
Wasmtime GitHub notifications bot (Mar 10 2021 at 17:17):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Mar 10 2021 at 20:58):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 20:59):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 21:14):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 21:21):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 21:41):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 10 2021 at 23:39):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 00:56):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 01:01):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 01:08):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 01:27):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 01:54):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 02:45):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 02:48):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 04:26):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 11 2021 at 04:30):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 12 2021 at 04:57):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 12 2021 at 04:58):cfallin edited PR #2718 from new-backend to main:
This PR switches the default backend on x86, for both the
cranelift-codegencrate and for Wasmtime, to the new
(MachInst-style,VCode-based) backend that has been under
development and testing for some time now.The old backend is still available by default in builds with the
old-x86-backendfeature, or by requestingBackendVariant::Legacy
from the appropriate APIs.As part of that switch, it adds some more runtime-configurable plumbing
to the testing infrastructure so that tests can be run using the
appropriate backend.clif-util testis now capable of parsing a
backend selector option from filetests and instantiating the correct
backend.I has been updated so that the old x86 backend continues to run its
tests, just as we used to run the new x64 backend separately.At some point, we will remove the old x86 backend entirely, once we are
satisfied that the new backend has not caused any unforeseen issues and
we do not need to revert.This implements the switch described in bytecodealliance/rfcs#10; we should
not merge this until we reach consensus on the process described therein
and merge the RFC.
Wasmtime GitHub notifications bot (Mar 26 2021 at 01:19):jlb6740 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 26 2021 at 01:19):jlb6740 created PR Review Comment:
What do the new file test targets (machinst and legacy) mean?
Wasmtime GitHub notifications bot (Mar 26 2021 at 01:19):jlb6740 deleted PR Review Comment.
Wasmtime GitHub notifications bot (Mar 30 2021 at 21:30):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 31 2021 at 01:06):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 31 2021 at 17:24):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 31 2021 at 17:24):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 31 2021 at 17:24):alexcrichton created PR Review Comment:
ditto to above
Wasmtime GitHub notifications bot (Mar 31 2021 at 17:24):alexcrichton created PR Review Comment:
Is this still needed or was this a temporary addition?
Wasmtime GitHub notifications bot (Mar 31 2021 at 17:24):alexcrichton created PR Review Comment:
or rather, if it's still needed, mind adding a comment as to why?
Wasmtime GitHub notifications bot (Mar 31 2021 at 22:16):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Mar 31 2021 at 22:16):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Mar 31 2021 at 22:16):cfallin created PR Review Comment:
Ah, this appears to have been left over -- we seem to have fixed the warning subsequently. Removed!
Wasmtime GitHub notifications bot (Mar 31 2021 at 22:16):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Mar 31 2021 at 22:16):cfallin created PR Review Comment:
Removed!
Wasmtime GitHub notifications bot (Apr 02 2021 at 18:36):cfallin updated PR #2718 from new-backend to main.
Wasmtime GitHub notifications bot (Apr 05 2021 at 16:38):cfallin merged PR #2718.
Last updated: Nov 22 2024 at 17:03 UTC