Stream: git-wasmtime

Topic: wasmtime / PR #2703 Document the `-Wl,--stack-first` opti...

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:07):

sunfishcode opened PR #2703 from sunfishcode/docs to main:

As discussed in WebAssembly/wasi-libc#233, document the
-Wl,--stack-first option to help users diagnose stack overflow errors.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:11):

sbc100 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:11):

sbc100 created PR Review Comment:

Worth linking to https://lld.llvm.org/WebAssembly.html so folks find discover other useful linker flags?

How about For more information on this and other linker flags supported by wasm-ld see https://lld.llvm.org/WebAssembly.html.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:19):

Rochet2 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:19):

Rochet2 created PR Review Comment:

Interesting. Seems that some useful flags are not described on the page, such as --growable-table and --export. I assume it is not actively being updated. Maybe ./wasm-ld --help would be more extensive, but one cannot see it online. It's also not described on that page of flags.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:24):

sbc100 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:24):

sbc100 created PR Review Comment:

It may be out of date, but that is not indented. Its generated directly from this file in the llvm source tree so it probably just needs an update: https://github.com/llvm/llvm-project/blob/main/lld/docs/WebAssembly.rst. Linking to something readable online is think is better than assuming the reader has a command line to hand.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:25):

sbc100 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:25):

sbc100 created PR Review Comment:

That document also has more useful information about the linker in addition to what --help provides.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:32):

sunfishcode updated PR #2703 from sunfishcode/docs to main.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:33):

sunfishcode submitted PR Review.

Wasmtime GitHub notifications bot (Mar 03 2021 at 20:33):

sunfishcode created PR Review Comment:

Good thought; I'd now added a link to the lld WebAssembly docs.

Wasmtime GitHub notifications bot (Mar 03 2021 at 21:01):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 03 2021 at 21:10):

sbc100 submitted PR Review.

Wasmtime GitHub notifications bot (Mar 03 2021 at 21:26):

sunfishcode merged PR #2703.

Last updated: Oct 23 2024 at 20:03 UTC