Stream: git-wasmtime

Topic: wasmtime / PR #2697 [x64] Add the new i64x2 comparisons

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:00):

abrown opened PR #2697 from i64x2-comparisons to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:02):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:02):

abrown created PR Review Comment:

I'm not sure if this is actually true for aarch64; @akirilov-arm, do you know? I'll move it down to the "aarch and x64" block if this actually runs with that backend.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:03):

abrown updated PR #2697 from i64x2-comparisons to main.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:06):

abrown edited PR #2697 from i64x2-comparisons to main:

i64x2 comparison instructions were added recently to the Wasm SIMD proposal. This PR adds those instructions to the x64 backend. The lowerings for some of these instructions already existed but those that didn't--i64x2.ge_s and i64x2.le_s--have been lowered by comparing the flipped operands with PCMPGTQ (in effect, asking to emit lt for ge and gt for le) and then negating the results.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:13):

abrown has marked PR #2697 as ready for review.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:13):

abrown requested cfallin and jlb6740 for a review on PR #2697.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:13):

abrown requested cfallin and jlb6740 for a review on PR #2697.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:33):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Mar 02 2021 at 01:52):

abrown merged PR #2697.

Wasmtime GitHub notifications bot (Mar 02 2021 at 12:43):

akirilov-arm submitted PR Review.

Wasmtime GitHub notifications bot (Mar 02 2021 at 12:43):

akirilov-arm created PR Review Comment:

Yes, the I64X2 comparisons have been implemented in the AArch64 backend - they just haven't been tested so far.

Last updated: Dec 23 2024 at 12:05 UTC