Wasmtime GitHub notifications bot (Feb 23 2021 at 22:27): Wasmtime GitHub notifications bot (Feb 23 2021 at 22:27):cfallin opened PR #2682 from shift-bugs to main:
This fixes #2672 and #2679, and also fixes an incorrect instruction
emission (testwith small immediate) that we had missed earlier.The shift-related fixes have to do with (i) shifts by 0 bits, as a
special case that must be handled; and (ii) shifts by a 128-bit amount,
which we can handle by just dropping the upper half (we only use 3--7
bits of shift amount).This adjusts the lowerings appropriately, and also adds run-tests to
ensure that the lowerings actually execute correctly (previously we only
had compile-tests with golden lowerings; I'd like to correct this for
more ops eventually, adding run-tests beyond what the Wasm spec and
frontend covers).<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 23 2021 at 22:27):cfallin requested abrown for a review on PR #2682.
Wasmtime GitHub notifications bot (Feb 25 2021 at 17:48):cfallin updated PR #2682 from shift-bugs to main.
Wasmtime GitHub notifications bot (Feb 25 2021 at 17:56):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Feb 26 2021 at 22:37):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Feb 26 2021 at 23:13):cfallin merged PR #2682.
Last updated: Dec 23 2024 at 13:07 UTC