Wasmtime GitHub notifications bot (Feb 23 2021 at 01:14): Wasmtime GitHub notifications bot (Feb 23 2021 at 01:14):abrown requested fitzgen for a review on PR #2677.
Wasmtime GitHub notifications bot (Feb 23 2021 at 01:14):abrown opened PR #2677 from bench-wasi-proposals to main:
This adds the ability to add feature flags (e.g.
--features wasi-nn) when compilingwasmtime-bench-apito allow benchmarking Wasmtime with WASI proposals included. Note that due to https://github.com/rust-lang/cargo/issues/5364, these features are only available:
- in the
crates/bench-apidirectory, e.g.pushd crates/bench-api; cargo build --features wasi-crypto- or from the top-level project directory using
-Zpackage-features, e.g.OPENVINO_INSTALL_DIR=/opt/intel/openvino cargo +nightly build -p wasmtime-bench-api -Zpackage-features --features wasi-nn<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 23 2021 at 15:18):alexcrichton merged PR #2677.
Last updated: Oct 23 2024 at 20:03 UTC