Stream: git-wasmtime

Topic: wasmtime / PR #2671 Clean up our github issue templates

Wasmtime GitHub notifications bot (Feb 19 2021 at 17:49):

fitzgen opened PR #2671 from issue-templates to main:

• Don't use HTML comments, as they are noisy, which makes the templates more
  intimidating.

• Use "TODO" to clearly demarcate everywhere the issue reporter should fill in
  some information.

• Use headers and white space abundantly, which makes it easier to visually
  process the template and its sections at a glance, and less of an intimidating
  wall of text.

Fixes #2661

Wasmtime GitHub notifications bot (Feb 19 2021 at 18:22):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Feb 19 2021 at 18:22):

bjorn3 created PR Review Comment:

There is still some inconsistency in casing between templates.

Wasmtime GitHub notifications bot (Feb 19 2021 at 18:30):

fitzgen updated PR #2671 from issue-templates to main.

Wasmtime GitHub notifications bot (Feb 19 2021 at 18:38):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Feb 19 2021 at 19:27):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Feb 19 2021 at 19:27):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Feb 19 2021 at 19:27):

abrown created PR Review Comment:

Cranelift version or commit: e.g., `git describe`?

Operating system: e.g., `uname -osr`

Architecture: e.g., `lscpu | egrep 'Architecture|Model name'`

Wasmtime GitHub notifications bot (Feb 19 2021 at 19:29):

abrown created PR Review Comment:

I mean, we might want to think up the Windows/MacOS versions of some of those but that would answer @wycats' comments here.

Wasmtime GitHub notifications bot (Feb 19 2021 at 19:29):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Feb 19 2021 at 20:02):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Feb 19 2021 at 20:02):

fitzgen created PR Review Comment:

This removes the TODO hints that every other field they need to fill out has, makes the template wordier (which makes it more like an intimidating wall of text), and assumes a unix environment. Not convinced that this change is a clear win.

Wasmtime GitHub notifications bot (Feb 19 2021 at 20:08):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Feb 19 2021 at 20:08):

cfallin created PR Review Comment:

+1 -- OS and architecture would likely be known by folks who would be reporting issues (we can always have a conversation in an issue if not or if we need more detail); whereas complex command pipelines make it look like we're asking for very specific and picky details and may scare folks away, I think.

Wasmtime GitHub notifications bot (Feb 19 2021 at 21:05):

fitzgen merged PR #2671.

Last updated: Nov 22 2024 at 17:03 UTC