Stream: git-wasmtime

Topic: wasmtime / PR #2659 Update to the next version of the wit...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 18:50):

alexcrichton opened PR #2659 from witx-next to main:

This commit updates to the 0.9 version of the witx crate implemented in
WebAssembly/wasi#395. This new version drastically changes code
generation and how we interface with the crate. The intention is to
abstract the code generation aspects and allow code generators to
implement much more low-level instructions to enable more flexible APIs
in the future. Additionally a bunch of *.witx files were updated in
the WASI repository.

It's worth pointing out, however, that wasi-common does not change as
a result of this change. The shape of the APIs that we need to implement
are effectively the same and the only difference is that the shim
functions generated by wiggle are a bit different.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 18:52):

alexcrichton requested pchickey for a review on PR #2659.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 20:46):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 20:46):

pchickey created PR Review Comment:

good catch!!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 20:47):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 20:47):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 21:43):

alexcrichton updated PR #2659 from witx-next to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 21:46):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 21:46):

alexcrichton created PR Review Comment:

@pchickey do you have thoughts on adding back the to/from abi repr traits? I originally removed them because I figured it was good to trim things down to just the in-memory type to avoid too many conversions being available, but it ended up showing up a good amount in tests.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 22:09):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 22:09):

pchickey created PR Review Comment:

I'm fine with either - using as in tests is OK with me, or maybe we should do types::Errno::try_from(res).unwrap() on the lhs? If you don't want to provide too many From impls maybe define a FromAbi trait in wiggle that has the same shape, but has docs saying its just for wiggle use?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 22:29):

alexcrichton updated PR #2659 from witx-next to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 22:37):

alexcrichton updated PR #2659 from witx-next to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 22:56):

alexcrichton updated PR #2659 from witx-next to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 15:51):

alexcrichton updated PR #2659 from witx-next to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 18:01):

alexcrichton updated PR #2659 from witx-next to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 19:18):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 22:44):

abrown submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 22:45):

abrown merged PR #2659.

Last updated: Oct 23 2024 at 20:03 UTC