Wasmtime GitHub notifications bot (Feb 16 2021 at 16:37): Wasmtime GitHub notifications bot (Feb 16 2021 at 16:37):cfallin requested alexcrichton and fitzgen for a review on PR #2655.
Wasmtime GitHub notifications bot (Feb 16 2021 at 16:37):cfallin requested alexcrichton and fitzgen for a review on PR #2655.
Wasmtime GitHub notifications bot (Feb 16 2021 at 16:37):cfallin opened PR #2655 from fix-warnings-beta to main:
Panic messages must now be string literals (we used
format!()in
many places;panic!()can take format strings directly).Some dead enum options with EVEX encoding stuff in old x86 backend.
This will go away soon and/or be moved to the new backend anyway, so
let's silence the warning for now.A few other misc warnings.
We're seeing these warnings in CI for #2653.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 16 2021 at 16:50):cfallin updated PR #2655 from fix-warnings-beta to main.
Wasmtime GitHub notifications bot (Feb 16 2021 at 16:52):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Feb 16 2021 at 18:48):abrown created PR Review Comment:
:+1:
Wasmtime GitHub notifications bot (Feb 16 2021 at 18:48):abrown submitted PR Review.
Wasmtime GitHub notifications bot (Feb 16 2021 at 20:15):cfallin closed without merge PR #2655.
Last updated: Nov 22 2024 at 16:03 UTC