Stream: git-wasmtime

Topic: wasmtime / PR #2654 Add methods to construct RexFlags fro...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 01:53):

kaseyc opened PR #2654 from rex to main:

This unifies the logic around Rex prefix emission and hopefully makes REX prefix errors less likely.

There are still several instructions that use other sources to determine the flags, so set_w and clear_w are left as is.
closes #2586.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 17:54):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 17:54):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 17:54):

cfallin created PR Review Comment:

It might be a little cleaner / more type-safe to take an (OperandSIze, Reg) tuple here (and use int_reg_enc()), I think.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 02:40):

kaseyc updated PR #2654 from rex to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 02:42):

kaseyc updated PR #2654 from rex to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 02:43):

kaseyc submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 02:43):

kaseyc created PR Review Comment:

Done.

For consistency I also changed always_emit_if_8bit_needed to also take a Reg as its argument.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 02:48):

kaseyc updated PR #2654 from rex to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 03:26):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 03:27):

cfallin merged PR #2654.

Last updated: Nov 22 2024 at 16:03 UTC