Wasmtime GitHub notifications bot (Feb 09 2021 at 23:56): Wasmtime GitHub notifications bot (Feb 09 2021 at 23:56):pchickey opened PR #2651 from pch/wasi_windows_paths_2642 to main:
This is based off the report at
https://github.com/bytecodealliance/wasmtime/issues/2642. We narrowed down that issue to #2650. This code is not sophisticated enough to reproduce that issue, and I'm not sure how we could add a test that ensures cap-std handles UNC paths correctly, but at any rate this test seems useful to have.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 09 2021 at 23:56):pchickey edited PR #2651 from pch/wasi_windows_paths_2642 to main:
This is based off the report of https://github.com/bytecodealliance/wasmtime/issues/2642. We narrowed down that issue to #2650. This code is not sophisticated enough to reproduce that issue, and I'm not sure how we could add a test that ensures cap-std handles UNC paths correctly, but at any rate this test seems useful to have.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 09 2021 at 23:57):pchickey requested sunfishcode for a review on PR #2651.
Wasmtime GitHub notifications bot (Feb 10 2021 at 00:04):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Feb 10 2021 at 00:04):sunfishcode created PR Review Comment:
Did you intend to comment out the body of main and use a fixed fd here?
Wasmtime GitHub notifications bot (Feb 10 2021 at 00:48):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Feb 10 2021 at 00:48):pchickey created PR Review Comment:
Oops! I was making sure that didnt make a difference and forgot to back it out...
Wasmtime GitHub notifications bot (Feb 10 2021 at 00:49):pchickey updated PR #2651 from pch/wasi_windows_paths_2642 to main.
Wasmtime GitHub notifications bot (Feb 10 2021 at 01:23):pchickey requested sunfishcode for a review on PR #2651.
Wasmtime GitHub notifications bot (Feb 11 2021 at 00:54):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Feb 11 2021 at 00:54):sunfishcode merged PR #2651.
Last updated: Dec 23 2024 at 12:05 UTC